Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

okhttp: remove irrelevant logs for non-android platform #11567

Closed
wants to merge 1 commit into from
Closed

okhttp: remove irrelevant logs for non-android platform #11567

wants to merge 1 commit into from

Conversation

ghmulti
Copy link

@ghmulti ghmulti commented Sep 27, 2024

We are using the io.grpc:grpc-okhttp library on the backend, and it appears that this warning is irrelevant for non-Android platforms. However, this false-positive warning triggers log alarms, which is very unfortunate.

Copy link

CLA Missing ID CLA Not Signed

@ejona86
Copy link
Member

ejona86 commented Sep 27, 2024

PLATFORM will be null at that point, as those methods are being used to initialize platform. We should instead delete the warning (and delete the method's comment saying it will log on failure).

@larry-safran larry-safran added the Waiting on reporter there was a request for more information without a response or answer or advice has been provided label Sep 28, 2024
@ejona86
Copy link
Member

ejona86 commented Oct 2, 2024

#11591 was merged in favor of this PR.

@ejona86 ejona86 closed this Oct 2, 2024
@ghmulti
Copy link
Author

ghmulti commented Oct 8, 2024

Nice, thanks for fixing this! 👏 😎

@ghmulti ghmulti deleted the fix/okhttp-platform-logging branch October 8, 2024 06:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Waiting on reporter there was a request for more information without a response or answer or advice has been provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants