core: combined epoch seconds and nanos changes in TimeProvider #11604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' into defect-5494-timeprovider-changes
kannanjgithub
previously approved these changes
Oct 10, 2024
| @@ -0,0 +1,43 @@ | |||
| /* | |||
| * Copyright 2017 The gRPC Authors | |||
kannanjgithub
previously approved these changes
Oct 10, 2024
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
reviewed
Oct 17, 2024
vinodhabib
changed the title
ejona86
reviewed
Oct 23, 2024
core/src/main/java/io/grpc/internal/TimeProviderResolverFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/TimeProviderResolverFactory.java
Outdated
Show resolved
Hide resolved
core/src/test/java/io/grpc/internal/InstantTimeProviderTest.java
Outdated
Show resolved
Hide resolved
ejona86
reviewed
Oct 24, 2024
core/src/test/java/io/grpc/internal/InstantTimeProviderTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/io/grpc/internal/InstantTimeProviderTest.java
Outdated
Show resolved
Hide resolved
ejona86
approved these changes
Oct 24, 2024
kannanjgithub
approved these changes
Oct 28, 2024
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
diegomarquezp
added a commit
to googleapis/sdk-platform-java
that referenced
this pull request
Jan 24, 2025
### Approach Register `java.time.Instant` to the reflection configuration of gax-grpc (see [grpc code interacting with this class](grpc/grpc-java#11604)) This comes from a behavior change in Graal for JDK 22, which introduced a new class initialization strategy called strict image heap, which is [enforced by default since then](https://www.graalvm.org/release-notes/JDK_22/). ### Proof: ``` com.google.showcase.v1beta1.EchoClientTest > blockExceptionTest SUCCESSFUL Test run finished after 95953 ms [ 30 containers found ] [ 0 containers skipped ] [ 30 containers started ] [ 0 containers aborted ] [ 30 containers successful ] [ 0 containers failed ] [ 337 tests found ] [ 1 tests skipped ] [ 336 tests started ] [ 0 tests aborted ] [ 336 tests successful ] [ 0 tests failed ] [INFO] [INFO] --- jacoco:0.8.12:report (report) @ gapic-showcase --- [INFO] Loading execution data file /usr/local/google/home/diegomarquezp/google/sdk-platform-java/showcase/gapic-showcase/target/jacoco.exec [INFO] Analyzed bundle 'GAPIC Showcase Client' with 125 classes [WARNING] Classes in bundle 'GAPIC Showcase Client' do not match with execution data. For report generation the same class files must be used as at runtime. [WARNING] Execution data for class com/google/showcase/v1beta1/stub/HttpJsonSequenceServiceStub does not match. [WARNING] Execution data for class com/google/showcase/v1beta1/stub/HttpJsonMessagingCallableFactory does not match. [WARNING] Execution data for class com/google/showcase/v1beta1/stub/HttpJsonSequenceServiceCallableFactory does not match. [WARNING] Execution data for class com/google/showcase/v1beta1/stub/HttpJsonTestingCallableFactory does not match. [WARNING] Execution data for class com/google/showcase/v1beta1/stub/HttpJsonTestingStub does not match. [WARNING] Execution data for class com/google/showcase/v1beta1/stub/HttpJsonMessagingStub does not match. [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for GAPIC Showcase Client Core Parent 0.0.1-SNAPSHOT: [INFO] [INFO] GAPIC Showcase Client Core Parent .................. SUCCESS [ 1.709 s] [INFO] proto-gapic-showcase-v1beta1 ....................... SUCCESS [ 0.900 s] [INFO] grpc-gapic-showcase-v1beta1 ........................ SUCCESS [ 0.385 s] [INFO] GAPIC Showcase Client .............................. SUCCESS [05:29 min] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 05:34 min [INFO] Finished at: 2025-01-20T19:04:42Z [INFO] ------------------------------------------------------------------------ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes to get the Timestamp in epoch nanoseconds.
Fixes #5494