Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deframe failures should be logged on the server as warnings #11645

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Deframe failures should be logged on the server as warnings #11645

merged 1 commit into from
Nov 5, 2024

Conversation

niloc132
Copy link
Contributor

This brings grpc-servlet in line with the grpc-netty implementation found in NettyServerStream.TransportState.

@niloc132
Deframe failures should be logged on the server as warnings
37fca51 
This brings grpc-servlet in line with the grpc-netty implementation found
in NettyServerStream.TransportState.
ejona86
ejona86 approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we need this. Not that we want warnings on server-side, but since the cancellation won't propagate error details to the client we need to log at a visible log level so the error isn't completely lost.

@ejona86 ejona86 requested a review from kannanjgithub November 1, 2024 20:52
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 4, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Nov 4, 2024
@ejona86 ejona86 merged commit a5db67d into grpc:master Nov 5, 2024
14 of 15 checks passed
@ejona86
Copy link
Member

ejona86 commented Nov 5, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannanjgithub kannanjgithub kannanjgithub approved these changes

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niloc132 @ejona86 @kannanjgithub @grpc-kokoro