fix security issue with okhttp #11749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZachChuba
force-pushed
the
okhttp-host
branch
from
5cf8ca2 to
714119f
Compare
ZachChuba
force-pushed
the
okhttp-host
branch
from
714119f to
210d8f3
Compare
ejona86
reviewed
Dec 16, 2024
okhttp/third_party/okhttp/main/java/io/grpc/okhttp/internal/OkHostnameVerifier.java
Show resolved
Hide resolved
okhttp/third_party/okhttp/main/java/io/grpc/okhttp/internal/OkHostnameVerifier.java
Outdated
Show resolved
Hide resolved
okhttp/third_party/okhttp/main/java/io/grpc/okhttp/internal/OkHostnameVerifier.java
Outdated
Show resolved
Hide resolved
ejona86
added
the
TODO:backport
larry-safran
approved these changes
Dec 16, 2024
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
larry-safran
added
the
kokoro:run
ejona86
pushed a commit
to ejona86/grpc-java
that referenced
this pull request
Jan 15, 2025
* Validate that hostname is ascii in OkHostnameVerifier.java
ejona86
pushed a commit
to ejona86/grpc-java
that referenced
this pull request
Jan 15, 2025
* Validate that hostname is ascii in OkHostnameVerifier.java
This was referenced Jan 15, 2025
ejona86
pushed a commit
to ejona86/grpc-java
that referenced
this pull request
Jan 15, 2025
* Validate that hostname is ascii in OkHostnameVerifier.java
ejona86
pushed a commit
to ejona86/grpc-java
that referenced
this pull request
Jan 15, 2025
* Validate that hostname is ascii in OkHostnameVerifier.java
This was referenced Jan 15, 2025
ejona86
removed
the
kokoro:run
ejona86
pushed a commit
that referenced
this pull request
Jan 15, 2025
* Validate that hostname is ascii in OkHostnameVerifier.java
ejona86
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Validate that hostname is ascii in OkHostnameVerifier.java
ejona86
removed
the
TODO:backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement fix to address a security issue related to maliciously crafted hostnames during certificate validation in OkHttp
grpc-java is susceptible to CVE-2021-0341
This mirrors the okhttp patch for this exploit available in square/okhttp#6353