Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: allow LBv2 impls to be stripped out by ProGuard. #2654

Merged
merged 2 commits into from
Jan 25, 2017
Merged

core: allow LBv2 impls to be stripped out by ProGuard. #2654

merged 2 commits into from
Jan 25, 2017

Conversation

zhangkun83
Copy link
Contributor

This should address the concern of increased method count as mentioned
in #2650.

@zhangkun83
core: allow LBv2 impls to be stripped out by ProGuard.
e3dd421 
This should address the concern of increased method count as mentioned
in grpc#2650.
ejona86
ejona86 approved these changes Jan 25, 2017
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that LoadBalancer2 and ManagedChannelImpl2 are stripped by ProGuard.

@zhangkun83 zhangkun83 merged commit 0428556 into grpc:master Jan 25, 2017
@zhangkun83 zhangkun83 deleted the contain_impl2 branch January 25, 2017 23:06
@zhangkun83 zhangkun83 mentioned this pull request Jan 25, 2017
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees

@ejona86 ejona86

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangkun83 @ejona86