Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: security requirement of NameResolver.getServiceAuthority() #2665

Merged
merged 1 commit into from
Jan 27, 2017
Merged

docs: security requirement of NameResolver.getServiceAuthority() #2665

merged 1 commit into from
Jan 27, 2017

Conversation

zhangkun83
Copy link
Contributor

In response to #2662

@zhangkun83 zhangkun83 requested review from ejona86 and jboeuf January 27, 2017 01:36
@zhangkun83
Copy link
Contributor Author

cc @kkaneda @lukaszx0

lukaszx0
lukaszx0 approved these changes Jan 27, 2017
View reviewed changes
Copy link
Contributor

@lukaszx0 lukaszx0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

jboeuf
jboeuf approved these changes Jan 27, 2017
View reviewed changes
Copy link
Contributor

@jboeuf jboeuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for this.

@kkaneda
Copy link
Contributor

kkaneda commented Jan 27, 2017

yes, thanks!

@zhangkun83 zhangkun83 merged commit 9983a7b into grpc:master Jan 27, 2017
@zhangkun83 zhangkun83 deleted the getauthority branch January 27, 2017 17:27
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lukaszx0 lukaszx0 lukaszx0 approved these changes

@ejona86 ejona86 ejona86 approved these changes

@jboeuf jboeuf jboeuf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zhangkun83 @kkaneda @lukaszx0 @ejona86 @jboeuf