Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.gradle: bump protobuf plugin to 0.8.5 #4101

Merged
merged 2 commits into from
Mar 27, 2018

Conversation

zpencer
Copy link
Contributor

@zpencer zpencer commented Feb 20, 2018

This update automatically adds generated sources and proto IDLs to the
idea plugin, so clean up the configs.

@zpencer zpencer requested a review from zhangkun83 February 20, 2018 17:59
@zhangkun83
Copy link
Contributor

We don't want to use 0.8.4 because of google/protobuf-gradle-plugin#212. Please wait for google/protobuf-gradle-plugin#214 to be released.

This update automatically adds generated sources and proto IDLs to the
`idea` plugin.
@zpencer zpencer force-pushed the protobufplugin-0.8.4 branch from af092c0 to 66f23b6 Compare March 26, 2018 23:11
@zpencer zpencer changed the title build.gradle: bump protobuf plugin to 0.8.4 build.gradle: bump protobuf plugin to 0.8.5 Mar 26, 2018
@zpencer
Copy link
Contributor Author

zpencer commented Mar 26, 2018

@zhangkun83 PTAL

@zpencer zpencer force-pushed the protobufplugin-0.8.4 branch from 66f23b6 to 39cc757 Compare March 26, 2018 23:55
@zpencer zpencer merged commit 14003c1 into grpc:master Mar 27, 2018
@zpencer zpencer deleted the protobufplugin-0.8.4 branch March 27, 2018 00:29
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants