api, core: make scheduled executor service accessible for NameResolver.Args #6455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utorService as it needs to be shared for name resolver as well.
…mpl for NameResolver.Args.
ejona86
reviewed
Nov 21, 2019
| @@ -39,6 +40,7 @@ | |||
| .setProxyDetector(mock(ProxyDetector.class)) | |||
| .setSynchronizationContext(new SynchronizationContext(mock(UncaughtExceptionHandler.class))) | |||
| .setServiceConfigParser(mock(ServiceConfigParser.class)) | |||
| .setScheduledExecutorService(mock(ScheduledExecutorService.class)) | |||
| @@ -116,6 +117,7 @@ public void uncaughtException(Thread t, Throwable e) { | |||
| .setProxyDetector(GrpcUtil.DEFAULT_PROXY_DETECTOR) | |||
| .setSynchronizationContext(syncContext) | |||
| .setServiceConfigParser(mock(ServiceConfigParser.class)) | |||
| .setScheduledExecutorService(mock(ScheduledExecutorService.class)) | |||
There was a problem hiding this comment.
This one too. Is it necessary to set it? Can we leave it unset everywhere it is unused?
There was a problem hiding this comment.
Sure. It doesn't matter much. I set it just for completeness.
There was a problem hiding this comment.
I'm mainly requesting it because it makes the tests more bug-prone. As it is now if the code starts using the scheduled executor service it will throw and then it is clear a FakeClock needs to be injected. With the mock it just silently doesn't do anything.
ejona86
approved these changes
Nov 21, 2019
ericgribkoff
pushed a commit
to ericgribkoff/grpc-java
that referenced
this pull request
Dec 6, 2019
…r.Args (grpc#6455) Added new API on NameResolver.Args to access ScheduledExecutorService, which is wrapped transport executor.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.