Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: grpc-netty-shaded runtime scope #8798

Merged
merged 2 commits into from
Jan 4, 2022
Merged

readme: grpc-netty-shaded runtime scope #8798

merged 2 commits into from
Jan 4, 2022

Conversation

danielnorberg
Copy link
Contributor

We should recommend runtime scope for grpc-netty-shaded.

#8606 (comment)

readme: grpc-netty-shaded runtime scope
17ab4c8 
We should recommend runtime scope for grpc-netty-shaded.

grpc#8606 (comment)
@danielnorberg danielnorberg mentioned this pull request Jan 4, 2022
Closed
dapengzhang0
dapengzhang0 approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@dapengzhang0 dapengzhang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ejona86

ejona86
ejona86 approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. We do that in the examples, but not the README.

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jan 4, 2022
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jan 4, 2022
@ejona86
Copy link
Member

ejona86 commented Jan 4, 2022

The macos CI is broken at the moment, it should be fixed soon. (We're upgrading the version of OS X that is being used, and it had some other changes, like the Java version being used.)

@ejona86 ejona86 merged commit 24e345c into grpc:master Jan 4, 2022
@ejona86
Copy link
Member

ejona86 commented Jan 4, 2022

@danielnorberg, thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

@dapengzhang0 dapengzhang0 dapengzhang0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielnorberg @ejona86 @dapengzhang0 @grpc-kokoro