Make extra trailer behavior consistent with old code

grpc · Jan 31, 2024 · 7c9a5e7 · 7c9a5e7
1 parent f52d142
commit 7c9a5e7
Showing 1 changed file with 2 additions and 13 deletions.
diff --git a/packages/grpc-js/src/server-call.ts b/packages/grpc-js/src/server-call.ts
@@ -56,14 +56,11 @@ export type ServerDuplexStream<RequestType, ResponseType> = ServerSurfaceCall &
   ObjectReadable<RequestType> &
   ObjectWritable<ResponseType> & { end: (metadata?: Metadata) => void };
 
-export function serverErrorToStatus(error: ServerErrorResponse | ServerStatusResponse, extraTrailers?: Metadata | undefined): PartialStatusObject {
+export function serverErrorToStatus(error: ServerErrorResponse | ServerStatusResponse, overrideTrailers?: Metadata | undefined): PartialStatusObject {
   const status: PartialStatusObject = {
     code: Status.UNKNOWN,
     details: 'message' in error ? error.message : 'Unknown Error',
-    metadata:
-      'metadata' in error && error.metadata !== undefined
-        ? error.metadata
-        : null,
+    metadata: overrideTrailers ?? error.metadata ?? null
   };
 
   if (
@@ -77,14 +74,6 @@ export function serverErrorToStatus(error: ServerErrorResponse | ServerStatusRes
       status.details = error.details!;
     }
   }
-
-  if (extraTrailers) {
-    if (status.metadata) {
-      status.metadata.merge(extraTrailers);
-    } else {
-      status.metadata = extraTrailers;
-    }
-  }
   return status;
 }