fix: update long to v5
#2192
Merged
fix: update long to v5
#2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`long` ships with types now
|
#2111 was fixed in googleapis/gax-nodejs#1253. The two other PRs just seems to try to deal with the fallout from that before |
murgatroid99
approved these changes
Aug 16, 2022
|
Sweet! Not sure if there's anything I'm supposed to do about the test failure? Seems spurious at first glance |
|
No, it's fine. |
|
This is now out in v0.7.1 |
|
Unfortunately this broke gax again, so I had to revert it in 0.7.2. |
|
😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protobufjs@7(#2167) comes with it, so aligning seems sensible to me