Skip to content

Commit

Permalink
Remove v2 code from v1
Browse files Browse the repository at this point in the history
Motivation:

There's a bug in SwiftPM which prohibits the Xcode build system from
being used if a dependency explicitly declares which Swift language mode
is being used, regardless of its value. A number of users are running
into this problem, and while it's not a gRPC Swift bug we can work
around the issue by removing the v2 code from the v1 branch and removing
the Swift 6 specific manifest.

Modifications:

- Remove all v2 code
- Remove workarounds in the SwiftPM build plugin which avoid deprecation
  warnings. It turns out that the guard was incorrect anyway: the API
  isn't guarded by the compiler version, but the package tools version.

Result:

Possible to build v1 with SwiftPM using the Xcode build system.
  • Loading branch information
glbrntt committed Nov 8, 2024
1 parent 3ef3a9f commit 8c500d3
Show file tree
Hide file tree
Showing 265 changed files with 10 additions and 52,078 deletions.
27 changes: 0 additions & 27 deletions Examples/v2/echo/Echo.swift

This file was deleted.

493 changes: 0 additions & 493 deletions Examples/v2/echo/Generated/echo.grpc.swift

This file was deleted.

129 changes: 0 additions & 129 deletions Examples/v2/echo/Generated/echo.pb.swift

This file was deleted.

35 changes: 0 additions & 35 deletions Examples/v2/echo/Subcommands/ClientArguments.swift

This file was deleted.

59 changes: 0 additions & 59 deletions Examples/v2/echo/Subcommands/Collect.swift

This file was deleted.

59 changes: 0 additions & 59 deletions Examples/v2/echo/Subcommands/Expand.swift

This file was deleted.

54 changes: 0 additions & 54 deletions Examples/v2/echo/Subcommands/Get.swift

This file was deleted.

Loading

0 comments on commit 8c500d3

Please sign in to comment.