Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cocoapods build configuration (Podspec is broken) #11

Closed
timburks opened this issue Jan 8, 2017 · 1 comment · Fixed by #207
Closed

Cocoapods build configuration (Podspec is broken) #11

timburks opened this issue Jan 8, 2017 · 1 comment · Fixed by #207

Comments

@timburks
Copy link
Member

timburks commented Jan 8, 2017

I've put an initial podspec in SwiftGRPC.podspec and put a reference to it in Examples/Speech/Podfile. Attempting to build it has a few problems:

  1. #import "internal.h" needs to be removed from the automatically-generated SwiftGRPC-umbrella.h.
  2. The CgRPC code refers to grpc_slice and the latest tagged version of gRPC-Core uses the older gpr_slice.
@timburks timburks changed the title Cocoapods build configuration Cocoapods build configuration (Podspec is broken) Jan 8, 2017
@MrMage
Copy link
Collaborator

MrMage commented Feb 19, 2018

Have a look at the s.public_header_files line in Timing-GmbH@9f2c674 on how to remove #import "internal.h" from the umbrella header. Happy to send a pull request once others have confirmed that spec to be working for them.

MrMage added a commit to Timing-GmbH/grpc-swift that referenced this issue Oct 16, 2018
Contains the following commits:
- Refactor gRPC decoding into dedicated codec classes.
- Start work on GRPCServerHandler.
- Add a "unary call handler" and use that for the tests.
- Refactoring starting a GRPC server into a dedicated class.
- Fix sending unary responses.
- Add a handler for client-streaming calls.
- Also implement bidirectional-streaming calls.
- Make sure to flush in server-streaming calls after each sent message.
- Add the missing test cases to `allTests`.
- Refactor `StatusSendingHandler` into its own class.
- Rename `GRPCServerHandler` to `GRPCChannelHandler`.
- Remove a FIXME.
- Add a few more comments.
- Attach the actual call handlers as channel handlers instead of manually forwarding messages to them.

# This is the commit message grpc#2:

Remove SwiftGRPCNIO's dependency on SwiftGRPC and move the responsibility for encoding GRPC statuses to HTTP1ToRawGRPCServerCoded.

# This is the commit message grpc#3:

Temporarily disable two test cases that are failing at the moment.

# This is the commit message grpc#4:

Add SwiftGRPCNIO as an exposed library.

# This is the commit message grpc#5:

Another try at getting CI to work with SwiftGRPCNIO.

# This is the commit message grpc#6:

More dependency fixes.

# This is the commit message grpc#7:

Add `SwiftGRPCNIO.EchoServerTests` to LinuxMain.swift.

# This is the commit message grpc#8:

Fix a string comparison in `.travis-install.sh`.

# This is the commit message grpc#9:

Add nghttp2 to the list of CI dependencies.

# This is the commit message grpc#10:

Another try with installing nghttp2 via brew.

# This is the commit message grpc#11:

Another try at using libnghttp2-dev under Ubuntu 14.04.

# This is the commit message grpc#12:

More Travis fixes.

# This is the commit message grpc#13:

One last try.

# This is the commit message grpc#2:

Disable two more tests for now, as they sometimes fail on CI.

# This is the commit message grpc#3:

Make Carthage debug builds verbose.

# This is the commit message grpc#4:

Only use SwiftGRPC-Carthage.xcodeproj for Carthage builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants