Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider crashes if not polled ?? #325

Closed
adirburke opened this issue Oct 29, 2018 · 3 comments · Fixed by #630
Closed

Provider crashes if not polled ?? #325

adirburke opened this issue Oct 29, 2018 · 3 comments · Fixed by #630

Comments

@adirburke
Copy link

adirburke commented Oct 29, 2018

Hi All,

My Provider Server crashes if it is not polled for awhile

In Server.swift it is crashing on this line:

func run(handleFunction:)

// block while waiting for an incoming request
          let event = self.completionQueue.wait(timeout: 600)

I have attached the trace from Xcode not sure where to beginning in trying to find
screen shot 2018-10-30 at 9 39 59 am

@MrMage
Copy link
Collaborator

MrMage commented Oct 30, 2018

Looks like this could be the same issue as #280.

What platform are you running this on? iOS or Mac?

@adirburke
Copy link
Author

Hi Mage, I am using on Mac, I will try the work around used in that thread

@adirburke
Copy link
Author

adirburke commented Oct 31, 2018

Hey Mage, do you know why the timeout was set to 600 for the wait ??

Server.swift:
   func run(handlerFunction:)
   79:    let event = self.completionQueue.wait(timeout: 600)

The default server keep-alive is 7200000, I think the timeout should be increased this timeout or you need to set your Channel.Argument.keepAliveTime(600) when creating the client

Otherwise '-1' just sets the timeout to time in distant future ("the workaround")

Ill make a pull request on the weekend, which method would you prefer ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants