Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a crash when hitting a timeout while waiting for the next call. #630

Merged
merged 3 commits into from
Nov 13, 2019
Merged

Fix a crash when hitting a timeout while waiting for the next call. #630

merged 3 commits into from
Nov 13, 2019

Conversation

MrMage
Copy link
Collaborator

@MrMage MrMage commented Nov 13, 2019 •
edited
Loading

Fixes #280, fixes #525, fixes #325.

@MrMage MrMage requested a review from glbrntt November 13, 2019 11:35
@MrMage MrMage mentioned this pull request Nov 13, 2019
Closed
glbrntt
glbrntt approved these changes Nov 13, 2019
View reviewed changes
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- can you update the documentation before merging?

Sources/SwiftGRPC/Core/Server.swift Show resolved Hide resolved
Sources/SwiftGRPC/Core/Server.swift Show resolved Hide resolved
@MrMage
Copy link
Collaborator Author

MrMage commented Nov 13, 2019

LGTM -- can you update the documentation before merging?

Sorry, added the documentation now.

@glbrntt glbrntt merged commit 18be868 into grpc:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glbrntt glbrntt glbrntt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EXC_BAD_ACCESS after queue timeout Provider crashes if not polled ?? Segmentation fault: 11
2 participants
@MrMage @glbrntt