Add an Async Ping Pong streaming benchmark #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Unary benchmark already exists - adding a streaming benchmark completes very high level coverage. Modifications: Refactor Unary benchmaark to break out what's specific to that and add a second implementation of that broken out class which runs a streaming test. Result: Both Unary and Streaming benchmarks exist.
glbrntt
requested changes
Oct 22, 2020
| self.messagesPerStream == 0 || messagesSent < self.messagesPerStream { | ||
| messagesSent += 1 | ||
| startTime = endTime // Use end of previous request as the start of the next. | ||
| _ = streamingCall!.sendMessage(self.requestMessage) |
There was a problem hiding this comment.
We can avoid allocating the promise here: sendMessage(self.requestMessage, promise: nil)
Performance/QPSBenchmark/Sources/QPSBenchmark/Runtime/AsyncPingPongRequestMaker.swift
Show resolved
Hide resolved
| // Setup the call. | ||
| streamingCall = self.client.streamingCall(handler: handleResponse) | ||
| // Kick start with initial request | ||
| _ = streamingCall!.sendMessage(self.requestMessage) |
There was a problem hiding this comment.
Avoid the promise: promise: nil
Co-authored-by: George Barnett <[email protected]>
glbrntt
reviewed
Oct 22, 2020
Performance/QPSBenchmark/Sources/QPSBenchmark/Runtime/AsyncClient.swift
Outdated
Show resolved
Hide resolved
glbrntt
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Unary benchmark already exists - adding a streaming benchmark
completes very high level coverage.
Modifications:
Refactor Unary benchmaark to break out what's specific to
that and add a second implementation of that broken out
class which runs a streaming test.
Result:
Both Unary and Streaming benchmarks exist.