Make the description of 'RPCTimedOut' static #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When printing the 'RPCTimedOut' error, the time limit is also included. Since these are often deadline based limits, the message is often unique: this makes it cumbersome to correlate timeout failures logs. Modifications: - Remove the `timeLimit` from the `description` of `RPCTimedOut`. Result: - `RPCTimedOut` failures are easier to correlate in logs.
Lukasa
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When printing the 'RPCTimedOut' error, the time limit is also included.
Since these are often deadline based limits, the message is often
unique: this makes it cumbersome to correlate timeout failures logs.
Modifications:
timeLimitfrom thedescriptionofRPCTimedOut.Result:
RPCTimedOutfailures are easier to correlate in logs.