Wire up the Call objects #1010
Merged
Wire up the Call objects #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Oct 26, 2020
| @@ -22,63 +22,60 @@ import NIOHTTP2 | |||
| /// | |||
| /// Messages should be sent via the `sendMessage` and `sendMessages` methods; the stream of messages | |||
| /// must be terminated by calling `sendEnd` to indicate the final message has been sent. | |||
| public final class BidirectionalStreamingCall< | |||
| public struct BidirectionalStreamingCall< | |||
There was a problem hiding this comment.
This struct still has reference semantics. It'd be good to clarify that in the doc comment. The same applies to the others.
There was a problem hiding this comment.
Ah, yes, that's certainly worth documenting.
Sources/GRPC/ClientCalls/Call.swift
Outdated
| let flush = next == nil | ||
|
|
||
| // Make a promise, store the future. | ||
| let promise = self.eventLoop.makePromise(of: Void.self) |
There was a problem hiding this comment.
Do we need a promise on every message? It seems sufficient to attach one to the last message, doesn't it? For streaming protocols like this you'd expect all these writes to fail with the same error.
There was a problem hiding this comment.
Hmm, I guess not? I suppose it's technically possible for one write to fail if a handler does something weirdo but practically speaking that's highly unlikely to happen. Let's save some allocations.
| @@ -43,6 +43,10 @@ internal final class ClientTransport<Request, Response> { | |||
| /// The current state of the transport. | |||
| private var state: State = .idle | |||
|
|
|||
| /// A lazy promise for the underlying `Channel`. We'll succeed this when we transition to `active` | |||
There was a problem hiding this comment.
Mild nit, but this promise isn't lazy.
Motivation:
We have the new `Call` object and a way to make calls. We should
refactory the existing `UnaryCall`, `ClientStreamingCall`, etc. to be
wrappers around `Call`.
Modifications:
- Reimplement the four call types on top of `Call`; these are now
implemented as structs.
- This required:
- some additional awkward logic in `Call` if the users requests the
stream `Channel` future
- removing requirements from `GRPCChannel` for constructing each call
type, and their concrete implementations. This is now done as an
extension.
Result:
- The four call objects are wired up so that they can use interceptors.
- Much less boilerplate
glbrntt
force-pushed
the
gb-feature-interceptors-06
branch
from
d682705 to
cc74c63
Compare
Lukasa
approved these changes
Oct 26, 2020
glbrntt
added a commit
that referenced
this pull request
Oct 29, 2020
Motivation:
We have the new `Call` object and a way to make calls. We should
refactory the existing `UnaryCall`, `ClientStreamingCall`, etc. to be
wrappers around `Call`.
Modifications:
- Reimplement the four call types on top of `Call`; these are now
implemented as structs.
- This required:
- some additional awkward logic in `Call` if the users requests the
stream `Channel` future
- removing requirements from `GRPCChannel` for constructing each call
type, and their concrete implementations. This is now done as an
extension.
Result:
- The four call objects are wired up so that they can use interceptors.
- Much less boilerplate
glbrntt
added a commit
that referenced
this pull request
Nov 6, 2020
Motivation:
We have the new `Call` object and a way to make calls. We should
refactory the existing `UnaryCall`, `ClientStreamingCall`, etc. to be
wrappers around `Call`.
Modifications:
- Reimplement the four call types on top of `Call`; these are now
implemented as structs.
- This required:
- some additional awkward logic in `Call` if the users requests the
stream `Channel` future
- removing requirements from `GRPCChannel` for constructing each call
type, and their concrete implementations. This is now done as an
extension.
Result:
- The four call objects are wired up so that they can use interceptors.
- Much less boilerplate
glbrntt
added a commit
that referenced
this pull request
Nov 12, 2020
Motivation:
We have the new `Call` object and a way to make calls. We should
refactory the existing `UnaryCall`, `ClientStreamingCall`, etc. to be
wrappers around `Call`.
Modifications:
- Reimplement the four call types on top of `Call`; these are now
implemented as structs.
- This required:
- some additional awkward logic in `Call` if the users requests the
stream `Channel` future
- removing requirements from `GRPCChannel` for constructing each call
type, and their concrete implementations. This is now done as an
extension.
Result:
- The four call objects are wired up so that they can use interceptors.
- Much less boilerplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We have the new
Callobject and a way to make calls. We shouldrefactory the existing
UnaryCall,ClientStreamingCall, etc. to bewrappers around
Call.Modifications:
Call; these are nowimplemented as structs.
Callif the users requests thestream
ChannelfutureGRPCChannelfor constructing each calltype, and their concrete implementations. This is now done as an
extension.
Result: