Reduce excessive server logging. #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When running a unary server, sending the response can put the HTTP1ToGRPCServerCodec into ignore state. This happens before the end of stream is processed. The 2 end stream messages (empty buffer of data and end) then trigger logging. Modifications: Ignore end and empty data without logging when codec is in ignore state. Result: Less logging and hence faster performance.
glbrntt
requested changes
Oct 23, 2020
Comment on lines
133
to
139
| if case let .body(body) = unwrappedData, body.readableBytes == 0 { | ||
| return // Ignoring a read of zero bytes is always fine. | ||
| } else if case .end = unwrappedData { | ||
| return // Ignoring an end stream is not an event worth reporting. | ||
| } | ||
| self.logger.notice("ignoring read data", metadata: ["data": "\(data)"]) | ||
| return |
There was a problem hiding this comment.
Can we switch on the unwrappedData here instead? We can drop our return count to 1 and neaten it up a bit.
Something like:
switch unwrappedData {
case let .body(body) where body.readableBytes == 0:
()
case .end:
()
default:
self.logger.notice(...)
}
return
}There was a problem hiding this comment.
Also we may as well log the unwrappedData instead of the data now.
There was a problem hiding this comment.
Also you'll need to run ./scripts/format.sh.
glbrntt
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When running a unary server, sending the response can put the
HTTP1ToGRPCServerCodec into ignore state. This happens before
the end of stream is processed. The 2 end stream messages
(empty buffer of data and end) then trigger logging.
Modifications:
Ignore end and empty data without logging when codec is in
ignore state.
Result:
Less logging and hence faster performance.