Tidy up some of the logic in the server call contexts #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The server call contexts rely on the service provider completing a promise, either for the response or status depending on the streaming type. Doing so then writes the relevant parts into the pipeline. However, we also have to deal with the promises being failed, and since the logic there is a little circuitous the callback chains were a little hard to follow and had some redundancy. Modifications: - Add a 'processError(_:delegate:)` to the base server call context to transform an error into a status and trailers. - Refactor the promise completion chains for the unary and streaming response call contexts. Result: - Code is easier to follow. Less duplication.
|
Could you review this @Davidde94? (I can't tag you as a reviewer.) |
Davidde94
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The server call contexts rely on the service provider completing a
promise, either for the response or status depending on the streaming
type. Doing so then writes the relevant parts into the pipeline.
However, we also have to deal with the promises being failed, and since
the logic there is a little circuitous the callback chains were a little
hard to follow and had some redundancy.
Modifications:
transform an error into a status and trailers.
response call contexts.
Result: