Rename the client interceptor methods #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The gRPC API usually refers to sending and receiving messages. The interceptor API uses 'write' and 'read' which are a little closer to the NIO API. We should bias to being more consistent with terms already used in the API. Modifications: - Rename 'write' to 'send', 'read' to 'receive' - Make the 'ClientInterceptor' methods 'open' - 'ClientInterceptorContext' methods delegate to a private implementation, this was done as the public methods ensured we were on the 'EventLoop' first. This is no longer the case so the indirection has been removed. Result: - Better naming
Lukasa
approved these changes
Oct 27, 2020
glbrntt
added a commit
that referenced
this pull request
Oct 29, 2020
Motivation: The gRPC API usually refers to sending and receiving messages. The interceptor API uses 'write' and 'read' which are a little closer to the NIO API. We should bias to being more consistent with terms already used in the API. Modifications: - Rename 'write' to 'send', 'read' to 'receive' - Make the 'ClientInterceptor' methods 'open' - 'ClientInterceptorContext' methods delegate to a private implementation, this was done as the public methods ensured we were on the 'EventLoop' first. This is no longer the case so the indirection has been removed. Result: - Better naming
glbrntt
added a commit
that referenced
this pull request
Nov 6, 2020
Motivation: The gRPC API usually refers to sending and receiving messages. The interceptor API uses 'write' and 'read' which are a little closer to the NIO API. We should bias to being more consistent with terms already used in the API. Modifications: - Rename 'write' to 'send', 'read' to 'receive' - Make the 'ClientInterceptor' methods 'open' - 'ClientInterceptorContext' methods delegate to a private implementation, this was done as the public methods ensured we were on the 'EventLoop' first. This is no longer the case so the indirection has been removed. Result: - Better naming
glbrntt
added a commit
that referenced
this pull request
Nov 12, 2020
Motivation: The gRPC API usually refers to sending and receiving messages. The interceptor API uses 'write' and 'read' which are a little closer to the NIO API. We should bias to being more consistent with terms already used in the API. Modifications: - Rename 'write' to 'send', 'read' to 'receive' - Make the 'ClientInterceptor' methods 'open' - 'ClientInterceptorContext' methods delegate to a private implementation, this was done as the public methods ensured we were on the 'EventLoop' first. This is no longer the case so the indirection has been removed. Result: - Better naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The gRPC API usually refers to sending and receiving messages. The
interceptor API uses 'write' and 'read' which are a little closer to the
NIO API. We should bias to being more consistent with terms already used
in the API.
Modifications:
implementation, this was done as the public methods ensured we were on
the 'EventLoop' first. This is no longer the case so the indirection
has been removed.
Result: