Codegen for client interceptors #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The changes are in ea1e537, the other commit is just regenerated code. |
Lukasa
approved these changes
Oct 28, 2020
Motivation: We have client interceptors wired all the way through but no convnenient way for them to be used. Modifications: - Generate an client interceptor factory which has a `make<Method>Interceptors()` function for each method on the service - The interceptor factory is an optional requirement on the generated client protocol, RPC invocations will pull interceptors from the factory, if present. Result: Users can provide interceptor factory implementations to their generated clients to use interceptors.
glbrntt
force-pushed
the
gb-feature-interceptors-07
branch
from
36e06fe to
5effb87
Compare
glbrntt
added a commit
that referenced
this pull request
Oct 29, 2020
Motivation: We have client interceptors wired all the way through but no convnenient way for them to be used. Modifications: - Generate an client interceptor factory which has a `make<Method>Interceptors()` function for each method on the service - The interceptor factory is an optional requirement on the generated client protocol, RPC invocations will pull interceptors from the factory, if present. Result: Users can provide interceptor factory implementations to their generated clients to use interceptors.
glbrntt
added a commit
that referenced
this pull request
Nov 6, 2020
Motivation: We have client interceptors wired all the way through but no convnenient way for them to be used. Modifications: - Generate an client interceptor factory which has a `make<Method>Interceptors()` function for each method on the service - The interceptor factory is an optional requirement on the generated client protocol, RPC invocations will pull interceptors from the factory, if present. Result: Users can provide interceptor factory implementations to their generated clients to use interceptors.
glbrntt
added a commit
that referenced
this pull request
Nov 12, 2020
Motivation: We have client interceptors wired all the way through but no convnenient way for them to be used. Modifications: - Generate an client interceptor factory which has a `make<Method>Interceptors()` function for each method on the service - The interceptor factory is an optional requirement on the generated client protocol, RPC invocations will pull interceptors from the factory, if present. Result: Users can provide interceptor factory implementations to their generated clients to use interceptors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We have client interceptors wired all the way through but no convnenient
way for them to be used.
Modifications:
make<Method>Interceptors()function for each method on the serviceclient protocol, RPC invocations will pull interceptors from the
factory, if present.
Result:
Users can provide interceptor factory implementations to their generated
clients to use interceptors.