Split path strings using UTF8 #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: For unary calls there can be a lot of path manipulation. Splitting in utf8 space is approximately 10x faster. Modifications: Hand craft a two part split using utf8. Result: Very small overall speed improvement (less than 1%)
|
For discussion on if this is worth it - makes things very slightly faster at the cost of more complex code. I'll not be upset if we decide not to do this as it ended up more complex than I originally thought it would be and the overall gains are quite small. |
Lukasa
reviewed
Nov 2, 2020
glbrntt
requested changes
Nov 2, 2020
Co-authored-by: Cory Benfield <[email protected]> Co-authored-by: George Barnett <[email protected]>
glbrntt
requested changes
Nov 3, 2020
| /// URI format: "/package.Servicename/MethodName" | ||
| init?(requestURI: String) { | ||
| var utf8View = requestURI.utf8[...] | ||
| guard utf8View.splitFirst(separator: self.pathSplitDelimiter)?.count == 0 else { |
There was a problem hiding this comment.
nit: isEmpty over count == 0
There was a problem hiding this comment.
I'm not sure you'll like my change here - I'm not sure I like it either but however you express this it's a little ugly.
glbrntt
reviewed
Nov 4, 2020
Co-authored-by: George Barnett <[email protected]>
glbrntt
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
For unary calls there can be a lot of path manipulation.
Splitting in utf8 space is approximately 10x faster.
Modifications:
Hand craft a two part split using utf8.
Result:
Very small overall speed improvement (less than 1%)