Use the server hostname override as the :authority, if present #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When using a secured connection to a server, the client may present a server hostname as part of the TLS SNI extension. However, the ':authority' header sent by the client will still just be the host the caller specified, rather than the server hostname. Modifications: - User the TLS server hostname override, if present, in prefernce to the hostname when setting the authority. Result: - Resolves grpc#1029
Davidde94
approved these changes
Nov 4, 2020
Lukasa
approved these changes
Nov 4, 2020
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Nov 6, 2020
Motivation: The generated code in the interceptors feature branch includes new protocol requirements. Some tests added recently in grpc#1033 to main don't meet these requirements. Modifications: - Add the missing requirements Result: Feature branch compiles when rebased on 'main'.
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Nov 6, 2020
Motivation: The generated code in the interceptors feature branch includes new protocol requirements. Some tests added recently in grpc#1033 to main don't meet these requirements. Modifications: - Add the missing requirements Result: Feature branch compiles when rebased on 'main'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When using a secured connection to a server, the client may present a
server hostname as part of the TLS SNI extension. However, the
':authority' header sent by the client will still just be the host the
caller specified, rather than the server hostname.
Modifications:
hostname when setting the authority.
Result: