Remove the 'error' case from the 'GRPCClientResponsePart' #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When implementing a bunch of interceptors I found it a little irksome having to deal with errors along with response parts. It feels more natural to deal with them separately. Modifications: - Remove 'error' from 'GRPCClientResponsePart' - Add an 'errorCaught' client interceptor function Result: Errors are handled separately to response parts.
Davidde94
approved these changes
Nov 5, 2020
How do you mean? |
PeterAdams-A
reviewed
Nov 6, 2020
|
@PeterAdams-A we don't have allocation counting tests yet |
|
@glbrntt |
Oh I see, that becomes a but ugly since the success type is also an enum. It's also against the motivation of the PR! |
PeterAdams-A
approved these changes
Nov 6, 2020
glbrntt
added a commit
that referenced
this pull request
Nov 6, 2020
Motivation: When implementing a bunch of interceptors I found it a little irksome having to deal with errors along with response parts. It feels more natural to deal with them separately. Modifications: - Remove 'error' from 'GRPCClientResponsePart' - Add an 'errorCaught' client interceptor function Result: Errors are handled separately to response parts.
glbrntt
added a commit
that referenced
this pull request
Nov 12, 2020
Motivation: When implementing a bunch of interceptors I found it a little irksome having to deal with errors along with response parts. It feels more natural to deal with them separately. Modifications: - Remove 'error' from 'GRPCClientResponsePart' - Add an 'errorCaught' client interceptor function Result: Errors are handled separately to response parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When implementing a bunch of interceptors I found it a little irksome
having to deal with errors along with response parts. It feels more
natural to deal with them separately.
Modifications:
Result:
Errors are handled separately to response parts.