Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single connection performance scenarios #1045

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Nov 19, 2020

Motivation:

Running the unconstrained performance benchmark on a development
machines yields results with a large amount of variance (I have seen
over 20% between runs in some cases) since all cores become fully
loaded. As such it's much harder to determine whether a change was
actually beneficial.

Modifications:

  • Add a single connection unary scenario, a copy of the unconstrained
    unary scenario but uses a single client such that only two threads are
    used: one for the server and one for the client.

Result:

  • Results with less variance between runs.

Motivation:

Running the unconstrained performance benchmark on a development
machines yields results with a large amount of variance (I have seen
over 20% between runs in some cases) since all cores become fully
loaded. As such it's much harder to determine whether a change was
actually beneficial.

Modifications:

- Add a single connection unary scenario, a copy of the unconstrained
  unary scenario but uses a single client such that only two threads are
  used: one for the server and one for the client.

Result:

- Results with less variance between runs.
@glbrntt glbrntt added the semver/none No version bump required. label Nov 19, 2020
@glbrntt glbrntt requested a review from Lukasa November 19, 2020 09:41
@glbrntt
Copy link
Collaborator Author

glbrntt commented Nov 19, 2020

cc @PeterAdams-A

@glbrntt glbrntt merged commit dcfaaae into grpc:main Nov 19, 2020
@glbrntt glbrntt deleted the gb-add-1-conn-scenarios branch December 10, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants