Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an HTTP/2 to raw gRPC server codec #1048

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Add an HTTP/2 to raw gRPC server codec #1048

merged 1 commit into from
Nov 20, 2020

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Nov 19, 2020

Motivation:

In #1041, we added an HTTP/2 to raw gRPC server state machine. To use it
we need to place it inside a ChannelHandler.

Modifications:

  • Add HTTP2ToRawGRPCServerCodec which wraps the
    HTTP2ToRawGRPCServerStateMachine.
  • No tests, since they'd largely duplicate those for the state machine,
    and other functional tests will test the same behavior.

Result:

  • A step closer to dealing primarily in HTTP/2 on the server.

@glbrntt
Add an HTTP/2 to raw gRPC server codec
ac1868b 
Motivation:

In grpc#1041, we added an HTTP/2 to raw gRPC server state machine. To use it
we need to place it inside a `ChannelHandler`.

Modifications:

- Add `HTTP2ToRawGRPCServerCodec` which wraps the
  `HTTP2ToRawGRPCServerStateMachine`.
- No tests, since they'd largely duplicate those for the state machine,
  and other functional tests will test the same behavior.

Result:

- A step closer to dealing primarily in HTTP/2 on the server.
@glbrntt glbrntt added the 🆕 semver/minor Adds new public API. label Nov 19, 2020
@glbrntt glbrntt requested a review from Lukasa November 19, 2020 13:58
@glbrntt glbrntt merged commit c687343 into grpc:main Nov 20, 2020
@glbrntt glbrntt deleted the gb-http2-to-grpc-handler branch November 20, 2020 09:03
@glbrntt glbrntt added 🔨 semver/patch No public API change. and removed 🆕 semver/minor Adds new public API. labels Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glbrntt @Lukasa