Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only generate services described in files in the codegen request #1058

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Only generate services described in files in the codegen request #1058

merged 1 commit into from
Nov 30, 2020

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Nov 27, 2020

Motivation:

Code should only be generated for files listed in the codegen request.
This regressed in #889.

Modifications:

  • Drive code generation from files to generate

Result:

Resolves #1057

@glbrntt
Only generate services described in files in the codegen request
b0137f9 
Motivation:

Code should only be generated for files listed in the codegen request.
This regressed in grpc#889.

Modifications:

- Drive code generation from files to generate

Result:

Resolves grpc#1057
@glbrntt glbrntt requested a review from Lukasa November 27, 2020 14:33
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Nov 27, 2020
@glbrntt glbrntt merged commit 42edec5 into grpc:main Nov 30, 2020
@glbrntt glbrntt deleted the gb-fix-codegen branch November 30, 2020 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

grpc-gen-swift generates all dependency protos instead of only requested ones
2 participants
@glbrntt @Lukasa