Generate client service name and proto service comments #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It can be useful to know the service path a client is for, particularly when constructing calls manually. Additionally, we include the methods comments for RPCs but not the service comments, they may be helpful in some cases. Modifications: - Generate the 'serviceName' for the client - Generate the proto source comments for the client and server Result: - Generated code is a touch more useful - Resolves grpc#962, grpc#1036
|
Changes in 34b78ff |
Lukasa
approved these changes
Nov 30, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It can be useful to know the service path a client is for, particularly
when constructing calls manually.
Additionally, we include the methods comments for RPCs but not the
service comments, they may be helpful in some cases.
Modifications:
Result: