Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify client channel pipeline setup #1064

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Dec 4, 2020

Motivation:

The client pipeline setup got a little complicated as it involves
calling various configure function and then adding handlers to various
ohter points. As such we end up creating a bunch of unnecessary futures.

Modifications:

  • Create an array of handlers we expect to add to the client pipeline

Result:

  • Code is simpler and easier to understand where each handler fits in.
  • I'd expect a small perf gain on connection setup but this wasn't measured.

Motivation:

The client pipeline setup got a little complicated as it involves
calling various configure function and then adding handlers to various
ohter points. As such we end up creating a bunch of unnecessary futures.

Modifications:

- Create an array of handlers we expect to add to the client pipeline

Result:

- Code is simpler and easier to understand where each handler fits in.
- I'd expect a small perf gain on connection setup but this wasn't measured.
@glbrntt glbrntt requested a review from Lukasa December 4, 2020 12:14
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Dec 4, 2020
@Lukasa Lukasa merged commit d9dd842 into grpc:main Dec 4, 2020
@glbrntt glbrntt deleted the gb-simplify-setup branch December 10, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants