Extract the logic from the GRPCIdleHandler into a state machine #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should add that PR doesn't add support for shutting down gracefully: it just paves the way for it. |
Lukasa
approved these changes
Dec 8, 2020
Motivation: Shutting down gracefully is generally a better option than slamming the door in the remote peer's face. To that end we need to do a better job of handling GOAWAY frames (both receiving and sending them). At the moment these are received by the 'GRPCIdleHandler' and used as an indication to close the connection. Since we also have to deal with various client connection management state the handler has grown a little out of hand. Modifications: - Pull the state machine out of the idle handler, add support for quiescing (to the state machine, not to the handler) Result: - Idle handler is way easier to follow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Shutting down gracefully is generally a better option than slamming the
door in the remote peer's face. To that end we need to do a better job
of handling GOAWAY frames (both receiving and sending them). At the
moment these are received by the 'GRPCIdleHandler' and used as an
indication to close the connection. Since we also have to deal with
various client connection management state the handler has grown a
little out of hand.
Modifications:
quiescing (to the state machine, not to the handler)
Result: