Drop support for Swift 5.0 #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Dec 9, 2020
Davidde94
approved these changes
Dec 9, 2020
glbrntt
force-pushed
the
gb-swift-support
branch
2 times, most recently
from
f541350 to
77b2040
Compare
Motivation: At this point Swift 5.0 is reasonably old; 5.1 has been around well over a year and most of the Swift on Server community adopts new Swift versions pretty quickly. Moreover, you have to go back to Xcode 10 to get a Swift 5.0 compiler on macOS. We should bump the minimum required Swift version before doing so is a breaking change. Modifications: - Raise minimum version to 5.1 - Update docs, CI, scaffolding etc. - Remove test manifests, use test discovery instead Result: - Swift 5.0 is no longer supported - Resolves grpc#1069
glbrntt
force-pushed
the
gb-swift-support
branch
from
77b2040 to
112f67c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
At this point Swift 5.0 is reasonably old; 5.1 has been around well over
a year and most of the Swift on Server community adopts new Swift versions
pretty quickly. Moreover, you have to go back to Xcode 10 to get a Swift
5.0 compiler on macOS. We should bump the minimum required Swift version
before doing so is a breaking change.
Modifications:
Result: