Remove a bunch of (unspecialized) generics #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The state machine code in the BaseCallHandler works returns an 'Action' to perform as a result of prodding the state machine. These actions are generic over the request and response type of the RPC as the often include instructions like 'forward this request to the interceptors' and so on. When these generics are unspecialized we burn a bunch of instructions in the runtime, and in many cases they can be represented without generics entirely. Modifications: - Shuffle some of the state machine code around in BaseCallHandler such that neither State or Action are generic Result: - Instructions executed in the unary server benchmark decreases by ~20%
glbrntt
force-pushed
the
gb-server-perf-actions
branch
from
975c611 to
87af230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The state machine code in the BaseCallHandler works returns an 'Action'
to perform as a result of prodding the state machine. These actions are
generic over the request and response type of the RPC as the often
include instructions like 'forward this request to the interceptors' and
so on. When these generics are unspecialized we burn a bunch of
instructions in the runtime, and in many cases they can be represented
without generics entirely.
Modifications:
that neither State or Action are generic
Result: