Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a unary server benchmark #1074

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Dec 9, 2020

Motivation:

Benchmarks are useful for measuring performance. We don't currently have
any benchmarks looking at just the server.

Modifications:

  • Add a benchmark to measure unary RPCs on an EmbededChannel on the
    server.

Result:

  • More benchmarks.

@glbrntt glbrntt requested a review from Lukasa December 9, 2020 15:36
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Dec 9, 2020
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shiny

Motivation:

Benchmarks are useful for measuring performance. We don't currently have
any benchmarks looking at just the server.

Modifications:

- Add a benchmark to measure unary RPCs on an EmbededChannel on the
  server.

Result:

- More benchmarks.
@glbrntt glbrntt force-pushed the gb-server-perf-test branch from 1529050 to 31c3a05 Compare December 10, 2020 09:18
@glbrntt glbrntt merged commit f6c6762 into grpc:main Dec 10, 2020
@glbrntt glbrntt deleted the gb-server-perf-test branch December 10, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants