Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the server to be gracefully shutdown. #1076

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Allow the server to be gracefully shutdown. #1076

merged 1 commit into from
Dec 11, 2020

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Dec 10, 2020

Motivation:

It should be possible to shutdown a server in a way which allows
existing connection to run to completion.

Modifications:

  • Add new API to allow servers to be initiate a graceful shutdown.
  • Add new API to the client connectivity delegate so that users can be
    informed that the connection is going away
  • Fixed a bug in the idle state machine that sent a GOAWAY frame too soon
    in response to receiving GOAWAY frame

Result:

Servers can be shutdown gracefully

@glbrntt
Allow the server to be gracefully shutdown.
609752c 
Motivation:

It should be possible to shutdown a server in a way which allows
existing connection to run to completion.

Modifications:

- Add new API to allow servers to be initiate a graceful shutdown.
- Add new API to the client connectivity delegate so that users can be
  informed that the connection is going away
- Fixed a bug in the idle state machine that sent a GOAWAY frame too soon
  in response to receiving GOAWAY frame

Result:

Servers can be shutdown gracefully
@glbrntt glbrntt requested a review from Lukasa December 10, 2020 15:17
@glbrntt glbrntt added the 🆕 semver/minor Adds new public API. label Dec 10, 2020
Lukasa
Lukasa approved these changes Dec 10, 2020
View reviewed changes
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice patch, I like this a lot.

@glbrntt glbrntt merged commit 59294d9 into grpc:main Dec 11, 2020
@glbrntt glbrntt deleted the gb-quiescing branch December 11, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
🆕 semver/minor Adds new public API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glbrntt @Lukasa