Make the remote address available on the server interceptor context #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Sometimes, if you're an interceptor, it's useful to know who you're talking too. Modifications: - Make the 'remoteAddress' available on the 'ServerInterceptorContext' Result: Users can access the remote address from server interceptors.
glbrntt
commented
Dec 16, 2020
| @@ -111,6 +111,7 @@ internal final class HTTP2ToRawGRPCServerCodec: ChannelDuplexHandler { | |||
| headers: payload.headers, | |||
| eventLoop: context.eventLoop, | |||
| errorDelegate: self.errorDelegate, | |||
| remoteAddress: context.channel.remoteAddress, | |||
There was a problem hiding this comment.
@Lukasa given this is in channelRead is it safe to force unwrap this optional?
There was a problem hiding this comment.
No, not all channels can answer this question.
Lukasa
approved these changes
Dec 16, 2020
| @@ -111,6 +111,7 @@ internal final class HTTP2ToRawGRPCServerCodec: ChannelDuplexHandler { | |||
| headers: payload.headers, | |||
| eventLoop: context.eventLoop, | |||
| errorDelegate: self.errorDelegate, | |||
| remoteAddress: context.channel.remoteAddress, | |||
There was a problem hiding this comment.
No, not all channels can answer this question.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Sometimes, if you're an interceptor, it's useful to know who you're
talking too.
Modifications:
Result:
Users can access the remote address from server interceptors.