Move client serialization into the transport handler #1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
approved these changes
Dec 16, 2020
glbrntt
force-pushed
the
gb-any-serializer
branch
from
da56774 to
26579c4
Compare
Motivation: Moving the client serialization into transport handler allows us to get rid of an unspecialized generic handler. Modifications: - Add an 'AnySerializer' and 'AnyDeserializer', this is unfortunate but necessary since 'ClientTransport' is generic over 'Request' and 'Response' rather than their respective (de/)serializer. Changing this would involve changing the generic constraints on all of the client call objects. - Move (de/)serialization into the 'ClientTransport' - Add a reverse codec for 'fake' transport Result: 3.5% fewer instructions in the unary_10k_small_requests benchmark.
glbrntt
force-pushed
the
gb-any-serializer
branch
from
26579c4 to
3bd5cf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Moving the client serialization into transport handler allows us to
get rid of an unspecialized generic handler.
Modifications:
necessary since 'ClientTransport' is generic over 'Request' and
'Response' rather than their respective (de/)serializer. Changing this
would involve changing the generic constraints on all of the client call
objects.
Result:
3.5% fewer instructions in the unary_10k_small_requests benchmark.