Fix some bugs with new handlers #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Manually wiring up the new handlers to run the rest of the test suite highlighted a few rough edges. Modifications: - Make sure compression is correctly set: it must be enabled on the server, in the call context, and - if applicable - on the individaul message - Call the error delegate in the right place - Add a 'protocol violation' error Result: Fewer bugs.
Lukasa
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Manually wiring up the new handlers to run the rest of the test suite
highlighted a few rough edges.
Modifications:
server, in the call context, and - if applicable - on the individaul
message. Add tests for this.
Result:
Fewer bugs.