Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimum Swift version to 5.2 #1106

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Raise minimum Swift version to 5.2 #1106

merged 1 commit into from
Jan 19, 2021

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Jan 19, 2021

Motivation:

We recently raised the minimum Swift version to 5.1; the community are
okay with us raising this further. Raising the supported version lowers
our support burden and unlocks new language features.

Modifications:

  • Use swift-tools-version:5.2, and update package description
  • Update .swiftformat
  • Update README
  • Drop 5.1 CI

Result:

Resolves #1072

Motivation:

We recently raised the minimum Swift version to 5.1; the community are
okay with us raising this further. Raising the supported version lowers
our support burden and unlocks new language features.

Modifications:

- Use swift-tools-version:5.2, and update package description
- Update .swiftformat
- Update README
- Drop 5.1 CI

Result:

Resolves grpc#1072
@glbrntt glbrntt added the ⚠️ semver/major Breaks existing public API. label Jan 19, 2021
@glbrntt glbrntt requested a review from Lukasa January 19, 2021 15:22
@glbrntt glbrntt merged commit 7dc3216 into grpc:main Jan 19, 2021
@glbrntt glbrntt deleted the gb-swift-5.2 branch January 19, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ semver/major Breaks existing public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we raise the minimum Swift version?
2 participants