Emit fewer flushes when handling RPCs on the server #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Jan 21, 2021
Motivation: The changes in grpc#1101 included a change in when flushes were emitted. For unary RPCs this led to an additional flush, which in some circumstances led to a drop in QPS of approximately 5%. Modifications: - Introduce an option as to whether a flush should be emitted when writing initial response metadata - Fix a bug where the request to flush or not for messages was ignored Result: A 5% increase in QPS for the unary-single benchmark (single connection, one rpc at a time).
Lukasa
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The changes in #1101 included a change in when flushes were emitted.
For unary RPCs this led to an additional flush, which in some
circumstances led to a drop in QPS of approximately 5%.
Modifications:
writing initial response metadata
Result:
A 5% increase in QPS for the unary-single benchmark (single connection,
one rpc at a time).