Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up some docs, add an faqs doc #1121

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Fix up some docs, add an faqs doc #1121

merged 2 commits into from
Feb 1, 2021

Conversation

glbrntt
Copy link
Collaborator

@glbrntt glbrntt commented Jan 29, 2021

Motivation:

Documentation is -- generally speaking -- useful. More so when it's
correct.

Modifications:

  • Add some missing documentation. There's still more to go but it's a
    start.
  • Add an 'faqs' doc which answers some questions which aren't necessarily
    obvious from reading source documentation. It's in no way
    comprehensive and is intended to be built upon over time.
  • Remove some dead code.

Result:

Better docs, hopefully.

Motivation:

Documentation is -- generally speaking -- useful. More so when it's
correct.

Modifications:

- Add some missing documentation. There's still more to go but it's a
  start.
- Add an 'faqs' doc which answers some questions which aren't necessarily
  obvious from reading source documentation. It's in no way
  comprehensive and is intended to be built upon over time.
- Remove some dead code.

Result:

Better docs, hopefully.
@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Jan 29, 2021
@glbrntt glbrntt requested a review from Lukasa January 29, 2021 14:08
docs/faqs.md Outdated Show resolved Hide resolved
Co-authored-by: Cory Benfield <[email protected]>
Copy link
Contributor

@Davidde94 Davidde94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really solid, especially the FAQ.

@glbrntt glbrntt merged commit c85a7ef into grpc:main Feb 1, 2021
@glbrntt glbrntt deleted the gb-docs branch February 1, 2021 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants