Update cocoapods and podspec script #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The podspec script uses Package.resolved to determine dependencies for the 'GRPC' module as well as version requirements. These version requirements are wrong per se, but they are overly restrictire. Additionally, while Package.resolved was previously correct, it no longer takes into account dependencies resolved for non-product targets (i.e. swift-argument-parser). Modifications: - Build podspec dependency requirements from 'swift package dump-package' - Replace 'os.system' with 'subprocess.check_call' - Update pods Result: Pod dependency requirementments match Package.swift
Lukasa
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The podspec script uses Package.resolved to determine dependencies for
the 'GRPC' module as well as version requirements. These version
requirements are wrong per se, but they are overly restrictire.
Additionally, while Package.resolved was previously correct, it no
longer takes into account dependencies resolved for non-product targets
(i.e. swift-argument-parser).
Modifications:
Result:
Pod dependency requirementments match Package.swift