Add a 'version' identifier and a more specific user-agent #1128
Conversation
Motivation: User-agent string should, ideally, contain a version number. Modifications: - Add a 'Version' struct - Use the version string in the user-agent - Only check user-provided headers for a user-agent string rather than all headers Result: - User-agent string includes version number
| internal static let minor = 0 | ||
|
|
||
| /// The patch version. | ||
| internal static let patch = 0 |
There was a problem hiding this comment.
How are we going to enforce updating this?
There was a problem hiding this comment.
I was also wondering about this. I'm not really sure at the moment because we have to update this before tagging a release, and anything that automates this check needs to know when a release is happening first.
One idea was to validate in CI against git tags, of course that only works after-the-fact so is of limited use, you can at least update it in a patch release straight after tough if the tag was wrong.
A release checklist has the problem as we have now the same as now: you need to remember to look at it.
The other idea I had was to build a check into the release notes drafter since I always run that before a release, definitely a hack though.
Any other ideas?
There was a problem hiding this comment.
I think that hack may be what we need to do for now, sadly.
| internal static let minor = 0 | ||
|
|
||
| /// The patch version. | ||
| internal static let patch = 0 |
There was a problem hiding this comment.
An extra question: should this also contain any version qualifiers, e.g. -alpha24?
There was a problem hiding this comment.
I'm being optimistic about what the next version is!
Motivation:
User-agent string should, ideally, contain a version number.
Modifications:
all headers
Result: