Better handle DATA frames with end stream set #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lukasa
reviewed
Feb 17, 2021
| /// set. However, we will tolerate end stream on a DATA frame providing we have received trailers | ||
| /// containing 'grpc-status' (i.e. we are in the 'clientClosedServerClosed' state). In cases where | ||
| /// we don't expect end of stream on a DATA frame we will emit a status with a message explaining | ||
| /// the protocol violation. |
There was a problem hiding this comment.
I'm a bit confused about this state description. When will we receive a DATA frame after having received a HEADERS frame that contains trailers? NIOHTTP2 enforces that the trailers header block must have END_STREAM, so no DATA frame on that stream may validly follow it. What have I missed?
There was a problem hiding this comment.
Ah, right, that's a good point. That was me assuming a state in which it could be valid. Really the case we tolerate it is "the rpc is already complete".
Motivation: If a peer doesn't follow spec and sends the client a DATA frame with end stream set, the client will ignore the fact that end stream was set. When the stream channel closes just after, the call is unaware of why it was closed (because it hasn't received a final status) which leads to a pretty non-descript error message. Modifications: Add a 'receiveEndOfResponseStream' to the client state machine which produces a 'GRPCStatus' if the end stream is unexpected and should not be ignored. Result: Calls will terminate with an 'internal error' status and a message about a protocol violation if the server sends a data frame with end stream set. Resolves grpc#1136
glbrntt
force-pushed
the
gb-handle-end-stream-data
branch
from
dbedaed to
be64c62
Compare
Lukasa
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
If a peer doesn't follow spec and sends the client a DATA frame with end
stream set, the client will ignore the fact that end stream was set.
When the stream channel closes just after, the call is unaware of why it
was closed (because it hasn't received a final status) which leads to a
pretty non-descript error message.
Modifications:
Add a 'receiveEndOfResponseStream' to the client state machine which
produces a 'GRPCStatus' if the end stream is unexpected and should not
be ignored.
Result:
Calls will terminate with an 'internal error' status and a message about
a protocol violation if the server sends a data frame with end stream
set.
Resolves #1136