Make storage on server contexts thread safe #1146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The properties on the server context passed to user functions aren't thread safe and require the user to be on the correct event loop to handle them correctly. That should be documented! Modifications: - More docs - Shim through computed properties with event-loop assertions Result: Better docs.
glbrntt
force-pushed
the
gb-server-context
branch
from
a220c3b to
b447780
Compare
Lukasa
approved these changes
Mar 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The properties on the server context passed to user functions aren't
thread safe and require the user to be on the correct event loop to
handle them correctly. That's not obvious nor is it documented.
Modifications:
Result:
Server context is thread-safe.