Use new NIO API for doing synchronous pipeline operations #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: SwiftNIO 2.27.0 added new API which allows channel handlers to be added synchronously when the caller know they are on the appropriate event loop. Doing so allows allocations to be saved. Modifications: - Use the synchronous operations helpers where possible. Result: Fewer allocations.
Lukasa
approved these changes
Mar 15, 2021
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Apr 8, 2021
Motivation: We can use synchronous pipeline operations to save some allocations. We converted to this new API in a handful of places in grpc#1149 but this one was missed. While NIOs async pipeline operations now use synchronous operations where possible (i.e. if already on the right event loop), they rely on having a cached void future to save allocations. This isn't yet supported by NIOTS, so we'll only save allocations there. Modifications: - Synchronously configure the client connection channel pipeline Result: Fewer allocations (when using NIOTS).
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Apr 8, 2021
Motivation: We can use synchronous pipeline operations to save some allocations. We converted to this new API in a handful of places in grpc#1149 but this one was missed. While NIOs async pipeline operations now use synchronous operations where possible (i.e. if already on the right event loop), they rely on having a cached void future to save allocations. This isn't yet supported by NIOTS, so we'll only save allocations there. Modifications: - Synchronously configure the client connection channel pipeline Result: Fewer allocations (when using NIOTS).
glbrntt
added a commit
to glbrntt/grpc-swift
that referenced
this pull request
Apr 8, 2021
Motivation: We can use synchronous pipeline operations to save some allocations. We converted to this new API in a handful of places in grpc#1149 but this one was missed. While NIOs async pipeline operations now use synchronous operations where possible (i.e. if already on the right event loop), they rely on having a cached void future to save allocations. This isn't yet supported by NIOTS, so we'll only save allocations there. Modifications: - Synchronously configure the client connection channel pipeline Result: Fewer allocations (when using NIOTS).
glbrntt
added a commit
that referenced
this pull request
Apr 8, 2021
Motivation: We can use synchronous pipeline operations to save some allocations. We converted to this new API in a handful of places in #1149 but this one was missed. While NIOs async pipeline operations now use synchronous operations where possible (i.e. if already on the right event loop), they rely on having a cached void future to save allocations. This isn't yet supported by NIOTS, so we'll only save allocations there. Modifications: - Synchronously configure the client connection channel pipeline Result: Fewer allocations (when using NIOTS).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
SwiftNIO 2.27.0 added new API which allows channel handlers to be added
synchronously when the caller know they are on the appropriate event
loop. Doing so allows allocations to be saved.
Modifications:
Result:
Fewer allocations.