Allocation counting tests for full RPC flows #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
force-pushed
the
gb-alloc-test-full-rpc
branch
from
66e61f2 to
aab291e
Compare
Lukasa
approved these changes
Apr 1, 2021
|
Hmm |
glbrntt
force-pushed
the
gb-alloc-test-full-rpc
branch
2 times, most recently
from
e497af7 to
ced9be9
Compare
Motivation: Now that we have an allocation counting test framework we should add tests to it! Modifications: - Add some common boilerplate for making an echo server and client - Add an allocation test for doing 1000 unary RPCs sequentially - Add allocation tests for doing 1000 bidi streaming RPCs sequentially, one where each RPC sends 1 request and another where each RPC sends 10 request. Result: More test coverage for allocations.
glbrntt
force-pushed
the
gb-alloc-test-full-rpc
branch
from
ced9be9 to
1dc0aef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Now that we have an allocation counting test framework we should add
tests to it!
Modifications:
one where each RPC sends 1 request and another where each RPC sends 10
request.
Result:
More test coverage for allocations.