Alllow calls to run on a specified event loop #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: It can be helpful for callers to know which event loop their RPCs are completed on. Currently the caller must hop to the desired event loop if it differs from the event loop used by the underlying transport. This can be tedious and error prone since it must be done in a number of places. Modifications: - Separate the event loop an RPC runs on (i.e. the one used for interceptors and response futures) and the event loop the RPC is transported on (i.e. the one used by the underlying 'Channel'). - Add an 'EventLoopPreference' to 'CallOptions' allowing users to specify they are 'indifferent' (the existing and default behaviour, use an event loop provided by the framework) or use an 'exact' event loop. - Add tests. Result: Callers can specify an event loop to run their RPCs on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
It can be helpful for callers to know which event loop their RPCs are
completed on. Currently the caller must hop to the desired event loop if
it differs from the event loop used by the underlying transport. This
can be tedious and error prone since it must be done in a number of
places.
Modifications:
interceptors and response futures) and the event loop the RPC is
transported on (i.e. the one used by the underlying 'Channel').
specify they are 'indifferent' (the existing and default behaviour,
use an event loop provided by the framework) or use an 'exact' event
loop.
Result:
Callers can specify an event loop to run their RPCs on.