A more general channel provider #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glbrntt
force-pushed
the
gb-channel-provider
branch
from
cda7d9c to
4efc5c0
Compare
Motivation: In grpc#1158 we pulled connection creation of the connection manager into a channel provider in order to loosen the coupling between the connection manager and `ClientConnection`. This change further decouples the `ConnectionManager` from the channel provider pulling out the relevant configuration into a `DefaultChannelProvider`. Modifications: - Refactor `ClientConnection.ChannelProvider` to rely on the bits of configuration it actually requires rather than `ClientConnection.Configuration` - Rename to `DefaultChannelProvider` Result: We can configure channels for the `ConnectionManager` without being tied to `ClientConnection`.
glbrntt
force-pushed
the
gb-channel-provider
branch
from
4efc5c0 to
9b2c1c0
Compare
Lukasa
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In #1158 we pulled connection creation of the connection manager into a
channel provider in order to loosen the coupling between the connection
manager and
ClientConnection. This change further decouples theConnectionManagerfrom the channel provider pulling out the relevantconfiguration into a
DefaultChannelProvider.Modifications:
ClientConnection.ChannelProviderto rely on the bits ofconfiguration it actually requires rather than
ClientConnection.ConfigurationDefaultChannelProviderResult:
We can configure channels for the
ConnectionManagerwithout being tiedto
ClientConnection.