Add a static-source Logger #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: swift-log includes a `source` field which -- in most cases -- should be the name of the module. Currently swift-log parses the `#file` to use the directory containing the file in the hope that it is the module name. In our tests we have a tear down step which validates that all caputred logs have 'GRPC' as their source. However, this requires manually providing the source in a bunch of places, that's a bit of a pain and only validates the logs we emit. Modifications: - Add an internal `GRPCLogger` which wraps a `Logger` providing only `trace` and `debug` (for now) and always sets the source to `GRPC`. Result: It's harder to get the source wrong.
Lukasa
approved these changes
Apr 22, 2021
|
@glbrntt I fixed that in SwiftLog: apple/swift-log#187 . It now uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
swift-log includes a
sourcefield which -- in most cases -- should bethe name of the module. Currently swift-log parses the
#fileto usethe directory containing the file in the hope that it is the module
name.
In our tests we have a tear down step which validates that all caputred
logs have 'GRPC' as their source. However, this requires manually
providing the source in a bunch of places, that's a bit of a pain and
only validates the logs we emit.
Modifications:
GRPCLoggerwhich wraps aLoggerproviding onlytraceanddebug(for now) and always sets the source toGRPC.Result:
It's harder to get the source wrong.